Skip to content

Commit

Permalink
remove stale comment
Browse files Browse the repository at this point in the history
  • Loading branch information
SeanNijjar committed Jan 25, 2025
1 parent bd4235a commit 486aa20
Showing 1 changed file with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,7 @@ struct WorkerToFabricEdmSender {
const uint64_t remote_buffer_index_addr = dest_noc_addr_coord_only | edm_buffer_index_addr;
noc_inline_dw_write(remote_buffer_index_addr, *this->buffer_index_ptr);

// Need to wait for the ack from edm
// We wait min because there is currently a race with worker <-> EDM teardown
// that will cause this to sometimes reach a value of 2 (because of the race)
// A proper fix requires for example adding an additional teardown semaphore on the
// worker side that the EDM writes to to acknowledge teardown. The problem here
// is that the flow control aliases the teardown.
// Need to wait for the ack to teardown notice, from edm
noc_semaphore_wait(this->worker_teardown_addr, 1);

noc_async_write_barrier();
Expand Down

0 comments on commit 486aa20

Please sign in to comment.