-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convenience Methods #183
Merged
Merged
Convenience Methods #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 95.25% 95.06% -0.19%
==========================================
Files 97 98 +1
Lines 16175 15954 -221
Branches 1547 1539 -8
==========================================
- Hits 15407 15166 -241
- Misses 525 537 +12
- Partials 243 251 +8
|
@hhsecond please review. |
rlizzo
force-pushed
the
convenience-methods
branch
from
March 7, 2020 08:16
8823268
to
ac21972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required? What problem does it solve?:
Added numerous convenience methods for general usage, major changes to the checkout column data reader API to allow support of arbitrary column layouts.
Description
Describe your changes in detail:
log
method to checkout instancesdiff
method toRepository
classdiff
commandAPI Changes to Checkout
__getitem__()
andget()
methods.Checkout object can be thought of as a "dataset" ("dset") mapping a
view of samples across columns.
Arbitrary column layouts are supported by simply adding additional members
to the keys for each piece of data. For example, getting data from a column
with a nested layout:
Retrieval of data from different column types can be mixed and combined
as desired. For example, retrieving data from both flat and nested columns
simultaneously:
If a column or data key does not exist, then this method will raise a KeyError.
As an alternative, missing keys can be gracefully handeled by calling :meth:
get()
instead. This method does not (by default) raise an error if a key is missing.
Instead, a (configurable) default value is simply inserted in it's place.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist: