Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namedtuple bugfix #161

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Namedtuple bugfix #161

merged 4 commits into from
Nov 11, 2019

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Nov 8, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

Fix incompatibility between set of possible names an Arrayset can take vs those valid namedtuple field names.

If it fixes an open issue, please link to the issue here:

Description

Describe your changes in detail:

  • Use built in namedtuple method to rename invalid fields with a positional index.
  • Fully documented behavior and implications; highlighting remaining limitations which remain even with this fix.
  • full test coverage?

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rlizzo rlizzo added Bug: Priority 3 No risk of data/record corruption or loss; No user facing impacts Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. labels Nov 8, 2019
@rlizzo rlizzo requested a review from hhsecond November 8, 2019 21:31
@rlizzo
Copy link
Member Author

rlizzo commented Nov 8, 2019

@hhsecond take a look and let me know if this is a proper solve for the issue?

@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #161 into master will increase coverage by <.01%.
The diff coverage is 96.98%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   95.21%   95.22%   +<.01%     
==========================================
  Files          63       63              
  Lines       11196    11393     +197     
  Branches      964      974      +10     
==========================================
+ Hits        10660    10848     +188     
- Misses        357      363       +6     
- Partials      179      182       +3
Impacted Files Coverage Δ
src/hangar/checkout.py 92.43% <100%> (+0.19%) ⬆️
tests/test_checkout_arrayset_access.py 99.13% <96.77%> (-0.71%) ⬇️
tests/test_remotes.py 97.97% <0%> (-0.55%) ⬇️

Copy link
Member

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rlizzo rlizzo added Resolved and removed Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. labels Nov 11, 2019
@rlizzo rlizzo merged commit 660ecfe into tensorwerk:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Priority 3 No risk of data/record corruption or loss; No user facing impacts Resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG REPORT] NamedTuple doesn't like all the name formats hangar allows
2 participants