Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "status", "commit", and "create-arrayset" to CLI #150

Merged
merged 8 commits into from
Oct 24, 2019

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Oct 23, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

Adding the ability to perform status, commit, and create arrayset operations from the command line interface.

If it fixes an open issue, please link to the issue here:

Description

Describe your changes in detail:

WIP, will update if necessary

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rlizzo rlizzo added enhancement New feature or request WIP Don't merge; Work in Progress labels Oct 23, 2019
@rlizzo rlizzo self-assigned this Oct 23, 2019
@rlizzo rlizzo changed the title Adding 'status', 'commit', and 'create-arrayset' to CLI Adding "status", "commit", and "create-arrayset" to CLI Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #150 into master will increase coverage by 1.67%.
The diff coverage is 98.69%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   93.17%   94.85%   +1.67%     
==========================================
  Files          62       63       +1     
  Lines       10974    11145     +171     
  Branches     1063      996      -67     
==========================================
+ Hits        10225    10571     +346     
+ Misses        525      386     -139     
+ Partials      224      188      -36
Impacted Files Coverage Δ
src/hangar/diagnostics/graphing.py 100% <ø> (+14.02%) ⬆️
src/hangar/diagnostics/ecosystem.py 100% <ø> (+20%) ⬆️
src/hangar/dataloaders/tfloader.py 100% <ø> (+25%) ⬆️
src/hangar/merger.py 95.38% <ø> (+7.69%) ⬆️
src/hangar/diff.py 96.31% <ø> (+13.11%) ⬆️
tests/test_cli.py 100% <100%> (ø) ⬆️
tests/test_remotes.py 98.51% <100%> (+0.74%) ⬆️
src/hangar/records/summarize.py 93.58% <100%> (+3.17%) ⬆️
src/hangar/__init__.py 100% <100%> (ø) ⬆️
src/hangar/arrayset.py 95.52% <100%> (+6.14%) ⬆️
... and 25 more

Checkout option is fully tested. Commit option still needs tests.

Checkout bug fixed. In cases where you checked out a branch on the CLI
for writing, and then opened a writer checkout in the API (without
specifying a branch), the default branch arg in the repo.checkout method
would reset the branch to `master`. Now, if no branch is provided, we
will use the branch of the latest writer checkout staging area. Tests
were updated to reflect this new behavior
@rlizzo rlizzo added Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. and removed WIP Don't merge; Work in Progress labels Oct 24, 2019
@rlizzo rlizzo requested a review from hhsecond October 24, 2019 03:47
Copy link
Member

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick glimpse looks good.

src/hangar/cli/cli.py Outdated Show resolved Hide resolved
src/hangar/cli/cli.py Outdated Show resolved Hide resolved
@rlizzo rlizzo merged commit 1442eea into tensorwerk:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] More options through command line interface
3 participants