-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "status", "commit", and "create-arrayset" to CLI #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlizzo
added
enhancement
New feature or request
WIP
Don't merge; Work in Progress
labels
Oct 23, 2019
rlizzo
changed the title
Adding 'status', 'commit', and 'create-arrayset' to CLI
Adding "status", "commit", and "create-arrayset" to CLI
Oct 23, 2019
rlizzo
force-pushed
the
new-cmdline-args
branch
from
October 23, 2019 21:18
2a421de
to
31ae3f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 93.17% 94.85% +1.67%
==========================================
Files 62 63 +1
Lines 10974 11145 +171
Branches 1063 996 -67
==========================================
+ Hits 10225 10571 +346
+ Misses 525 386 -139
+ Partials 224 188 -36
|
Checkout option is fully tested. Commit option still needs tests. Checkout bug fixed. In cases where you checked out a branch on the CLI for writing, and then opened a writer checkout in the API (without specifying a branch), the default branch arg in the repo.checkout method would reset the branch to `master`. Now, if no branch is provided, we will use the branch of the latest writer checkout staging area. Tests were updated to reflect this new behavior
rlizzo
force-pushed
the
new-cmdline-args
branch
from
October 24, 2019 03:47
f49d0fc
to
467f04c
Compare
rlizzo
added
Awaiting Review
Author has determined PR changes area nearly complete and ready for formal review.
and removed
WIP
Don't merge; Work in Progress
labels
Oct 24, 2019
rlizzo
force-pushed
the
new-cmdline-args
branch
from
October 24, 2019 14:04
111b23e
to
7965894
Compare
hhsecond
reviewed
Oct 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick glimpse looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Awaiting Review
Author has determined PR changes area nearly complete and ready for formal review.
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required? What problem does it solve?:
Adding the ability to perform
status
,commit
, andcreate arrayset
operations from the command line interface.If it fixes an open issue, please link to the issue here:
Description
Describe your changes in detail:
WIP, will update if necessary
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist: