Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial for dataloader #117

Merged
merged 2 commits into from
Sep 4, 2019
Merged

tutorial for dataloader #117

merged 2 commits into from
Sep 4, 2019

Conversation

hhsecond
Copy link
Member

Motivation and Context

Why is this change required? What problem does it solve?:

If it fixes an open issue, please link to the issue here:

Description

Describe your changes in detail:

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rlizzo rlizzo added the Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. label Aug 27, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #117 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   92.25%   92.38%   +0.13%     
==========================================
  Files          50       50              
  Lines        8622     8622              
  Branches      843      843              
==========================================
+ Hits         7954     7965      +11     
+ Misses        492      481      -11     
  Partials      176      176
Impacted Files Coverage Δ
src/hangar/backends/hdf5_00.py 90.38% <0%> (+4.23%) ⬆️

@rlizzo
Copy link
Member

rlizzo commented Sep 4, 2019

This looks good @hhsecond! Thanks for the writeup!

@rlizzo rlizzo merged commit 63bac60 into tensorwerk:master Sep 4, 2019
@hhsecond hhsecond deleted the tutorial_dataloaders branch September 4, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review Author has determined PR changes area nearly complete and ready for formal review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants