Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(python-sdk) Added graph validation for unreachable nodes. #1063

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

Default2882
Copy link
Contributor

@Default2882 Default2882 commented Nov 24, 2024

Context

This PR addresses #1033, which is to add graph validations for nodes which are not reachable from the start node.

Testing

Added new graph validation tests.

Contribution Checklist

  • [Done] If the python-sdk was changed, please run make fmt in python-sdk/.
  • [N/A] If the server was changed, please run make fmt in server/.
  • [Done] Make sure all PR Checks are passing.

@Default2882 Default2882 changed the title enhancement(python-sdk) Added graph validation for cyclic and unreachable nodes. enhancement(python-sdk) Added graph validation for unreachable nodes. Nov 25, 2024
@Default2882 Default2882 marked this pull request as ready for review November 25, 2024 14:22
@eabatalov eabatalov self-requested a review November 25, 2024 14:59
@eabatalov
Copy link
Contributor

Hi. Looks good to me. Thank you.

@eabatalov eabatalov merged commit 7dd2acc into tensorlakeai:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants