Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(sdk): fix using json encoding when using an api key #1050

Merged
merged 1 commit into from
Nov 20, 2024
Merged

bug(sdk): fix using json encoding when using an api key #1050

merged 1 commit into from
Nov 20, 2024

Conversation

seriousben
Copy link
Member

@seriousben seriousben commented Nov 20, 2024 •
edited
Loading

Context

Content-Type would be removed from headers when an API key was added.

What

When adding an API key merge it with the existing headers.

Testing

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben seriousben mentioned this pull request Nov 20, 2024
Open
@diptanu
Copy link
Collaborator

diptanu commented Nov 20, 2024

Amazing :D

@diptanu diptanu merged commit 47959a0 into main Nov 20, 2024
6 checks passed
@diptanu diptanu deleted the seriousben/fix-json-encoding-with-api-key branch November 20, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriousben @diptanu