Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP open-telemetry traces #1039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP open-telemetry traces #1039

wants to merge 1 commit into from

Conversation

seriousben
Copy link
Member

Context

What

Testing

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben
Copy link
Member Author

This needs better integration with axum's traces, especially with regards to error results before being ready.

It also needs configuration to toggle tracing export.

Otherwise, this PR works well with Jaeger.

@diptanu
Copy link
Collaborator

diptanu commented Dec 1, 2024

Whats left here?

@seriousben
Copy link
Member Author

This now only needs more spans and more instrument in the code as well as a configuration toggle for tracing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriousben @diptanu