Nightly test fixes #3208
Nightly test fixes #3208
Conversation
tafsiri
changed the title
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @tafsiri)
scripts/run-build.sh, line 22 at r1 (raw file):
if [[ -f "$DIR/run-ci" || "$NIGHTLY" = true ]]; then gcloud builds submit . --config=$DIR/cloudbuild.yml \ --substitutions _NIGHTLY=true
I see the PR has passed. Thank you Yannick! Please change this value back.
tafsiri
changed the title
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)
scripts/run-build.sh, line 22 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
I see the PR has passed. Thank you Yannick! Please change this value back.
Done. Just waiting on CI to finish, i'm getting a lot of browserstack disconnects. FYI tfjs-layers still tests firefox in non-nightly mode (that is what is disconnecting for me today). Should we switch that to just chrome?
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)
scripts/run-build.sh, line 22 at r1 (raw file):
Previously, tafsiri (Yannick Assogba) wrote…
Done. Just waiting on CI to finish, i'm getting a lot of browserstack disconnects. FYI tfjs-layers still tests firefox in non-nightly mode (that is what is disconnecting for me today). Should we switch that to just chrome?
Union package also tests in firefox by default.
|
@lina128 Ready for re-review, this passes CI even though it doesn't look like it, if you click into the failing test target, I've run it and it passes. I just can't run them all at the same time without something disconnecting. |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @lina128 and @tafsiri)
scripts/run-build.sh, line 22 at r1 (raw file):
Previously, tafsiri (Yannick Assogba) wrote…
Union package also tests in firefox by default.
I can move the firefox tests in a separate PR.
This PR (incorporating Na's change which made the webgl runs sequential in nightly) passes nightly.
It primarily fixes the webworker build, but also disables the cloud benchmark integration test, which seems to use an out of date approach to building packages, (yalc link, no build-deps etc). If this was in fact working since we moved to
link://style dependencies I can put this back, else it may have to wait until we refactor those integration tests more fully.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is