Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browserstack iPhone browser issue. #3204

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented May 4, 2020

This PR fixes browserstack iOS not responding issue. We have to use bs-local.com for localhost, see explanation on browserstack website: https://www.browserstack.com/question/759

The bs-local.com was accidentally removed, add it back.

This PR also include a couple of other small refactors:

  1. use singleRun only for CI, local run shouldn't use singleRun so that browser stays on for debugging.
  2. Use recommended config numbers for browserstack.

This change is Reviewable

@lina128 lina128 requested review from tafsiri and pyu10055 May 4, 2020 19:15
@lina128 lina128 changed the title Test nightly build. Fix browserstack iPhone browser issue. May 4, 2020
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out!

@lina128 lina128 merged commit 266d90d into tensorflow:master May 4, 2020
@lina128 lina128 deleted the fixfix2 branch May 4, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants