Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add split, sqrt kernels. #3183

Merged
merged 14 commits into from
May 7, 2020
Merged

[wasm] Add split, sqrt kernels. #3183

merged 14 commits into from
May 7, 2020

Conversation

annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Apr 30, 2020

These kernels are used by certain audio processing models.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@annxingyuan annxingyuan marked this pull request as ready for review May 4, 2020 11:23
@annxingyuan annxingyuan changed the title Wasm split [wasm] Add split, sqrt kernels. May 4, 2020
@annxingyuan annxingyuan self-assigned this May 4, 2020
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


tfjs-backend-wasm/src/kernels/Split.ts, line 20 at r1 (raw file):

import {NamedAttrMap, NamedTensorInfoMap, registerKernel, util} from '@tensorflow/tfjs-core';

import {TensorInfo} from '@tensorflow/tfjs-core';

combine TensorInfo with the previous import


tfjs-core/src/backends/split_shared.ts, line 20 at r1 (raw file):

import {Tensor} from '../tensor';

// TODO(annxingyuan): Use this helper in WASM Split kernel once intermediate

file an issue?

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat)


tfjs-backend-wasm/src/kernels/Split.ts, line 20 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

combine TensorInfo with the previous import

Done


tfjs-core/src/backends/split_shared.ts, line 20 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

file an issue?

Done

@annxingyuan annxingyuan merged commit d6ce518 into master May 7, 2020
@annxingyuan annxingyuan deleted the wasm_split branch May 7, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants