-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add split, sqrt kernels. #3183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Reviewed 8 of 8 files at r1.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-backend-wasm/src/kernels/Split.ts, line 20 at r1 (raw file):
import {NamedAttrMap, NamedTensorInfoMap, registerKernel, util} from '@tensorflow/tfjs-core'; import {TensorInfo} from '@tensorflow/tfjs-core';
combine TensorInfo with the previous import
tfjs-core/src/backends/split_shared.ts, line 20 at r1 (raw file):
import {Tensor} from '../tensor'; // TODO(annxingyuan): Use this helper in WASM Split kernel once intermediate
file an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @nsthorat)
tfjs-backend-wasm/src/kernels/Split.ts, line 20 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
combine TensorInfo with the previous import
Done
tfjs-core/src/backends/split_shared.ts, line 20 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
file an issue?
Done
These kernels are used by certain audio processing models.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is