Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test-integration. #2970

Merged
merged 3 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions cloudbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,6 @@ steps:
waitFor: ['find-affected-packages']
env: ['NIGHTLY=$_NIGHTLY']

# Integration tests
- name: 'node:10'
dir: 'tfjs-core'
id: 'test-integration'
entrypoint: 'yarn'
args: ['test-integration']
waitFor: ['find-affected-packages']
env: ['BROWSERSTACK_USERNAME=deeplearnjs1', 'NIGHTLY=$_NIGHTLY']
secretEnv: ['BROWSERSTACK_KEY']

# Release notes test
- name: 'node:10'
id: 'test-monorepo'
Expand All @@ -118,10 +108,6 @@ steps:
waitFor: ['yarn']

# General settings.
secrets:
- kmsKeyName: projects/learnjs-174218/locations/global/keyRings/tfjs/cryptoKeys/enc
secretEnv:
BROWSERSTACK_KEY: CiQAkwyoIW0LcnxymzotLwaH4udVTQFBEN4AEA5CA+a3+yflL2ASPQAD8BdZnGARf78MhH5T9rQqyz9HNODwVjVIj64CTkFlUCGrP1B2HX9LXHWHLmtKutEGTeFFX9XhuBzNExA=
timeout: 3600s
logsBucket: 'gs://tfjs-build-logs'
options:
Expand Down
1 change: 0 additions & 1 deletion tfjs-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
"test-node-ci": "node dist/test_node.js",
"test-async-backends": "rimraf dist/ && tsc && node dist/test_async_backends.js",
"test-async-backends-ci": "node dist/test_async_backends.js",
"test-integration": "yarn && ./scripts/test-integration.js",
"test-ci": "./scripts/test-ci.sh",
"test-snippets": "ts-node ./scripts/test_snippets/test_snippets.ts"
},
Expand Down
2 changes: 1 addition & 1 deletion tfjs-core/scripts/cloud_funcs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ gcloud functions deploy nightly \
```

If a build was triggered by nightly, there is a substitution variable `_NIGHTLY=true`.
You can forward the substitution as the `NIGHTLY` environment variable so the scripts can use it, by specifying `env: ['NIGHTLY=$_NIGHTLY']` in `cloudbuild.yml`. E.g. `test-integration` uses the `NIGHTLY` bit to always run on nightly.
You can forward the substitution as the `NIGHTLY` environment variable so the scripts can use it, by specifying `env: ['NIGHTLY=$_NIGHTLY']` in `cloudbuild.yml`.

### `send_email`
Sends an email and a chat message with the nightly build status. Every build sends a message to the `cloud-builds` topic with its build information. The `send_email` function is subscribed to that topic and ignores all builds (e.g. builds triggered by pull requests) **except** for the nightly build and sends an email to an internal mailing list with its build status around 3:10am.
Expand Down
38 changes: 0 additions & 38 deletions tfjs-core/scripts/test-integration.js

This file was deleted.

68 changes: 0 additions & 68 deletions tfjs-core/scripts/test-integration.sh

This file was deleted.