This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Hint javascript bundler to ignore fs, node-fetch, and string_decoder in package.browser
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Can you verify this solves the issue by using yalc in a fresh package? Then LGTM!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
dsmilkov
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Ha, didn't know we already had browser.fs : false . +1 to Nikhil's comment. Would be great to reproduce the angular setup that the user complained about in the issue. Thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:
|
Current |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using tfjs with angular-cli, it will show
can not resolve 'fs'error, because tfjs-data is usingfsin node environment. (original issue: angular/angular-cli#10681)So hint javascript bundler to ignore
fs,node-fetchandstring_decodethrough package.browser field.This resolves tensorflow/tfjs#1274
This change is