Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier comment #6928

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Prettier comment #6928

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b9fa1f
Adds a comment suggesting how to fix linter issues.
arcra Oct 16, 2024
d051c73
Testing command with multiple commits.
arcra Oct 17, 2024
844279d
Update command to work for multiple commits in the PR.
arcra Oct 17, 2024
8e8547d
Change to test CI failure.
arcra Oct 17, 2024
74af7b9
Update CI command to not fail when lint suceeds.
arcra Oct 17, 2024
309d335
Fixing linter issues.
arcra Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,9 @@ jobs:
with:
node-version: 16
- run: yarn install --ignore-engines
# You can run `yarn fix-lint` to fix all Prettier complaints.
- run: yarn lint
# You can run `yarn fix-lint` to fix all Prettier complaints, although at this point this will try to fix too many things.
# To fix only the files changed in this PR, see the command below.
- run: yarn lint || (( echo 'Try running `$ prettier --write $(git diff-tree --no-commit-id --name-only <latest commit> <parent branch commit> -r)`.' && false ))
# Make sure no tests are skipped with "focused" tests.
- run: |
! git grep -E 'f(it|describe)\(' 'tensorboard/*_test.ts'
Expand Down
Loading