Avoids bad protobuf version 4.24.0 #6746
Conversation
| werkzeug >= 1.0.1 |
There was a problem hiding this comment.
I don't know what this diff on L37 is trying to tell me but perhaps you could double check that there isn't something corrupted here.
There was a problem hiding this comment.
I think a line break was either added or removed at the end of file. Although I tried adding it back, and it was still showing a diff, so I'm not entirely sure. But I don't think this is an issue.
| @@ -24,7 +24,7 @@ numpy >= 1.12.0 | |||
| # At the same time, any constraints we specify here must allow at least some | |||
| # version to be installed that is also compatible with TensorFlow's constraints: | |||
| # https://github.com/tensorflow/tensorflow/blob/9d22f4a0a9499c8e10a4312503e63e0da35ccd94/tensorflow/tools/pip_package/setup.py#L100-L107 | |||
There was a problem hiding this comment.
Is the comment still valid? (seems to point to an old commit. The most up-to-date constraints look different than ours).
Also, is there an easy reference/link explaining what's wrong with 4.24.0 that we can also add to this comment?
There was a problem hiding this comment.
Updated the reference, but I think the comment is still valid. We don't need to have the exact same restrictions, we just need to have "at least some versions that is also compatible with TensorFlow's constraints".
I should have added this condition in #6660. At the time I thought it wouldn't matter much, as I assumed users would most likely get a newer version installed, but on second thought, it would be better to have this check, just in case.