HParams: Load spinner in data table and do not reload table #6658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Oct 23, 2023
bmd3k
pushed a commit
to bmd3k/tensorboard
that referenced
this pull request
Nov 2, 2023
…ow#6658) ## Motivation for features / changes Issue number 5 in tensorflow#6651. It is also just a better experience to keep previously loaded data intact while fetching new data. ## Technical description of changes In order to put the spinner below the headers I added the spinner to the data-table. It seems like a general feature that should be in that widget anyway. ## Screenshots of UI changes (or N/A) 
Merged
bmd3k
pushed a commit
that referenced
this pull request
Nov 2, 2023
## Motivation for features / changes Issue number 5 in #6651. It is also just a better experience to keep previously loaded data intact while fetching new data. ## Technical description of changes In order to put the spinner below the headers I added the spinner to the data-table. It seems like a general feature that should be in that widget anyway. ## Screenshots of UI changes (or N/A) 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Issue number 5 in #6651. It is also just a better experience to keep previously loaded data intact while fetching new data.
Technical description of changes
In order to put the spinner below the headers I added the spinner to the data-table. It seems like a general feature that should be in that widget anyway.
Screenshots of UI changes (or N/A)