Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCMigration: set padding in regex modal #6630

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

JamesHollyer
Copy link
Contributor

@JamesHollyer JamesHollyer commented Oct 10, 2023

Motivation for features / changes

Fixing regex since it looked pretty bad after MDC Migration. While doing this I also standardized the padding across the entire page to 16px.

Screenshots of UI changes (or N/A)

Before:
Screenshot 2023-10-10 at 11 46 33 AM

After:
Screenshot 2023-10-10 at 12 18 58 PM

Copy link
Contributor

@rileyajones rileyajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look better. Is there any chance you could change the color of the save button while you're at it?

@JamesHollyer
Copy link
Contributor Author

This does look better. Is there any chance you could change the color of the save button while you're at it?

I wan to get this in and then merge the MDCMigration branch today. Running another CI will just set me back to much.

@JamesHollyer JamesHollyer merged commit a0651da into tensorflow:MDCMigration Oct 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants