HParams: Enable hparamsInTimeSeries by default
#6565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
commented
Sep 1, 2023
| @@ -111,16 +111,16 @@ export class RunsDataTable { | |||
| } | |||
|
|
|||
| allRowsSelected() { | |||
| return this.data.every((row) => row['selected']); | |||
| return this.data?.every((row) => row['selected']); | |||
There was a problem hiding this comment.
These should never be undefined or null as long as the store exists, however, we have a funky test in tensorboard/webapp/metrics/metrics_integration_test.ts which checks the state of the app if the store is not defined.
JamesHollyer
approved these changes
Sep 18, 2023
Merged
rileyajones
added a commit
that referenced
this pull request
Sep 22, 2023
## Motivation for features / changes I let #6565 sit for a long time, then merged without rebasing. The result broke CI. This should fix it. When the PR was created the `enableHparamsInTimeSeries` was already imported, but between the PR creation and merge it was removed. https://github.com/rileyajones/tensorboard/blob/3cd4ce2e00a4e5fb0bb92e82a44d2fcdc8a7f13b/tensorboard/webapp/runs/effects/runs_effects_test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This PR will launch the hparams in timeseries feature.
Screenshots of UI changes (or N/A)
Light Mode
Dark Mode
Adding a column
Runs Table with additional columns
Applying an Interval Filter
Applying a Discrete Filter