Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade Angular (to 14) and related dependencies #6066

Merged
merged 3 commits into from
Nov 28, 2022
Merged

chore: Upgrade Angular (to 14) and related dependencies #6066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8192609
Upgrade Angular to version 14.
bmd3k Nov 18, 2022
43aab81
Format Vulcanize.java.
bmd3k Nov 22, 2022
3851411
Formatting ts files.
bmd3k Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
},
"homepage": "https://github.com/tensorflow/tensorboard#readme",
"devDependencies": {
"@angular-devkit/build-angular": "14.0.0-next.3",
"@angular-devkit/build-angular": "^14.2.9",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#fb42478534df7d48ec23a6834fea94a776cb89a0",
"@angular/cli": "^13.3.0",
"@angular/compiler": "^13.3.0",
"@angular/compiler-cli": "^13.3.0",
"@angular/cli": "^14.2.9",
"@angular/compiler": "14.2.11",
"@angular/compiler-cli": "^14.2.11",
"@babel/core": "^7.16.12",
"@bazel/concatjs": "5.7.0",
"@bazel/esbuild": "5.7.0",
Expand Down Expand Up @@ -61,22 +61,22 @@
"prettier-plugin-organize-imports": "2.3.4",
"requirejs": "^2.3.6",
"tslib": "^2.3.0",
"typescript": "4.5.4",
"typescript": "4.7.4",
"yarn-deduplicate": "^5.0.0"
},
"dependencies": {
"@angular/animations": "^13.3.0",
"@angular/cdk": "^13.3.0",
"@angular/common": "^13.3.0",
"@angular/core": "^13.3.0",
"@angular/forms": "^13.3.0",
"@angular/localize": "^13.3.0",
"@angular/material": "^13.3.0",
"@angular/platform-browser": "^13.3.0",
"@angular/platform-browser-dynamic": "^13.3.0",
"@angular/router": "^13.3.0",
"@ngrx/effects": "^13.2.0",
"@ngrx/store": "^13.2.0",
"@angular/animations": "^14.2.11",
"@angular/cdk": "^14.2.7",
"@angular/common": "14.2.11",
"@angular/core": "^14.2.11",
"@angular/forms": "^14.2.11",
"@angular/localize": "^14.2.11",
"@angular/material": "^14.2.7",
"@angular/platform-browser": "^14.2.11",
"@angular/platform-browser-dynamic": "^14.2.11",
"@angular/router": "^14.2.11",
"@ngrx/effects": "^14.3.2",
"@ngrx/store": "^14.3.2",
"@polymer/decorators": "^3.0.0",
"@polymer/iron-behaviors": "^3.0.1",
"@polymer/iron-collapse": "^3.0.1",
Expand Down Expand Up @@ -123,14 +123,14 @@
"marked": "^4.0.10",
"monaco-editor-core": "^0.26.0",
"monaco-languages": "^2.6.0",
"ngx-color-picker": "12.0.1",
"ngx-color-picker": "13.0.0",
"numeric": "^1.2.6",
"plottable": "^3.9.0",
"postinstall-postinstall": "^2.1.0",
"rxjs": "^7.4.0",
"rxjs": "^7.5.7",
"three": "~0.137.0",
"umap-js": "^1.3.2",
"web-animations-js": "^2.3.2",
"zone.js": "^0.11.6"
"zone.js": "^0.12.0"
}
}
2 changes: 1 addition & 1 deletion tensorboard/java/org/tensorflow/tensorboard/vulcanize/Vulcanize.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
public final class Vulcanize {

private static final Pattern INLINE_SOURCE_MAP_PATTERN =
Pattern.compile("//# sourceMappingURL=.*");
Pattern.compile("[^\"]//# sourceMappingURL=.*[^\"]");

private static final Parser parser = Parser.htmlParser();
private static final Map<Webpath, Path> webfiles = new HashMap<>();
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/notification_center/_views/notification_center_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ describe('notification center', () => {
dateInMs: 1,
title: 'test title',
content: 'test content',
fullNoteLink: "data:text/html,<script>alert('hi');</script>",
fullNoteLink: "javascript:alert('hi')",
},
]);
const fixture = TestBed.createComponent(NotificationCenterContainer);
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/util/ui_selectors_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
} from '../experiments/store/testing';
import {
buildFeatureFlag,
buildFeatureFlagState as buildFeatureFlagState,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly not entirely certain why the formatter now catches this. Perhaps it has something to do with the TypeScript upgrade.

buildFeatureFlagState,
buildState as buildStateFromFeatureFlagState,
} from '../feature_flag/store/testing';
import {
Expand Down
Loading