histogram: set v3 as default #5415
Conversation
There was a problem hiding this comment.
Actually, if you don't mind, I'd recommend that in this PR we just do only the cutover - i.e. let's not remove the v2 codepath yet. Just in case there are issues and we have to roll back, that makes the rollback as minimal as possible and avoids extra churn in the code.
For example, I think it would be enough to just do the following:
- in summary_v2.py
- rename
histogramtohistogram_v2 - add
histogram = histogram_v3at the bottom
- rename
- in summary_test.py
- update SummaryV2OpTest.call_histogram_op to invoke
histogram_v2instead of justhistogram
- update SummaryV2OpTest.call_histogram_op to invoke
| @@ -16,13 +16,20 @@ | |||
|
|
|||
| A histogram summary stores a list of buckets. Each bucket is encoded as | |||
| a triple `[left_edge, right_edge, count]`. Thus, a full histogram is | |||
| encoded as a tensor of dimension `[k, 3]`. | |||
| encoded as a tensor of dimension `[k, 3]`, where the first `k - 1` buckets | |||
There was a problem hiding this comment.
This module docstring is all referring to the legacy "tb.summary" APIs (for TensorFlow 1.x) that were defined in this file, which we aren't changing, so I think it's ok to just leave this docstring as-is (and only have the new format documented in summary_v2.py's docstring). At some point we should rearrange and clean this up so that's more obvious but probably best to do that for all the summary APIs vs piecemeal.
There was a problem hiding this comment.
Done. Thanks for the suggestion!
| histogram = summary_v2.histogram | ||
| histogram_pb = summary_v2.histogram_pb | ||
|
|
||
| # Export V3 versions. | ||
| histogram_v3 = summary_v2.histogram_v3 |
There was a problem hiding this comment.
Let's keep this one line for now, so that anyone who was testing this out internally won't be broken by this change?
* set histogram v3 as default * remove unused import * keep the v2 version for now * keep the v3 export to avoid breaking internal tests
* set histogram v3 as default * remove unused import * keep the v2 version for now * keep the v3 export to avoid breaking internal tests
Set V3 implementation as default, dynamic shapes will be eliminated.
Ran internally: cl/408885623
#histogram #tpu