Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeseries: fix button toggle state issue #5398

Merged
merged 2 commits into from
Nov 4, 2021
Merged

timeseries: fix button toggle state issue #5398

merged 2 commits into from
Nov 4, 2021

Commits on Nov 4, 2021

  1. timeseries: fix button toggle state issue 

    Angular material components are not truly "controlled input" that even
if the parent sets `checked` state to false, if user clicked on the
button from false to true to cause a redux state change that makes
parent put that state, it will have a value `checked`. This is directly
observable by printing out value of `checked` vs. value set by parent.

We work around this issue by simply using button that acts like a
checkbox instead of using an Angular material component. Also, styled
carefully to make it look about the same.
    @stephanwlee
    stephanwlee committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    f82d40e View commit details
    Browse the repository at this point in the history

  2. fix tests

    @stephanwlee
    stephanwlee committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    7436aa0 View commit details
    Browse the repository at this point in the history