layout: make resizer smaller #5390
Conversation
Previously, we used to have a little icon and thick vertical bar to make resize affordance apparent on the left pane resizer. After surveying modern apps, it looks like they are often done with pointer in combination with thicker vertical bar on hover so we adopt those designs. In the end, with this change, we give users about 18 pixels back in the horizontal space.
| @@ -30,22 +30,32 @@ limitations under the License. | |||
| .expand { | |||
| @include tb-theme-foreground-prop(border-color, border); | |||
| box-sizing: border-box; | |||
| flex: 0 0 20px; | |||
| flex: 0 0; | |||
There was a problem hiding this comment.
does this change anything?
the width of the expand is still depending on the width of the icon [>] (which is 19px and ~20px)
There was a problem hiding this comment.
Thanks for pointing that out. I forgot to add one file in my commit. I did remove the icon from the template.
There was a problem hiding this comment.
I checked again. What I mean was expand_more_24px
It seems to me (mac, chrome) the expand element does not change with and without flex attribute;
Yet the icon seems bigger (24px) with setting width (line 35)
I want to make sure these are intended change (the expander getting wider).
There was a problem hiding this comment.
I mean the icon is bigger (24px) without setting width of expand element (line 35)
There was a problem hiding this comment.
Ah, indeed you are correct. I have forgotten about the expander which is separate from the resize bar. Have put the width back on the expander.
so it needs to have width set.
|
Thank you for the thorough review and fast turn around! |
Previously, we used to have a little icon and thick vertical bar to make resize affordance apparent on the left pane resizer. After surveying modern apps, it looks like they are often done with pointer in combination with thicker vertical bar on hover so we adopt those designs. In the end, with this change, we give users about 18 pixels back in the horizontal space.
Previously, we used to have a little icon and thick vertical bar to make resize affordance apparent on the left pane resizer. After surveying modern apps, it looks like they are often done with pointer in combination with thicker vertical bar on hover so we adopt those designs. In the end, with this change, we give users about 18 pixels back in the horizontal space.
Previously, we used to have a little icon and thick vertical bar to make
resize affordance apparent on the left pane resizer. After surveying
modern apps, it looks like they are often done with pointer in
combination with thicker vertical bar on hover so we adopt those
designs.
In the end, with this change, we give users about 18 pixels back in the
horizontal space.
Before:
No hover:
Hover:
