Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

histogram: implement buckets_v3 #5356

Merged
merged 12 commits into from
Oct 7, 2021
Merged

histogram: implement buckets_v3 #5356

merged 12 commits into from
Oct 7, 2021

Commits on Oct 5, 2021

  1. rename functions to avoid confusion 

      Use `single_value` here, `singular` has unrelated mathematical meaning:
  https://en.wikipedia.org/wiki/Singularity_(mathematics).
    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    05d8c78 View commit details
    Browse the repository at this point in the history

  2. push the single_value test cases down to all test cases 

      Since v3 change the outcome for single value input, this enables the
  customization of these test cases.
    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    3ea37da View commit details
    Browse the repository at this point in the history

  3. add v3 implementation for single value input

    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    f0815dc View commit details
    Browse the repository at this point in the history

  4. add test got v3 graph ops 

      More tests for v3 pb ops will be added after histogram_pb_v3 is implemented.
    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    6774bea View commit details
    Browse the repository at this point in the history

  5. Revert "push the single_value test cases down to all test cases" 

    This reverts commit be2213cac544d17a9cec65e9e3b37a4c8a59d5d2.
    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    fffb21b View commit details
    Browse the repository at this point in the history

  6. check if bucket_count <= 0 and fix tf ops

    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    5bf44ad View commit details
    Browse the repository at this point in the history

  7. Make SummaryV3OpGraphTest inherit from V2 test case and add test for … 

    …zero bucket count
    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    3f4cfd3 View commit details
    Browse the repository at this point in the history

  8. use an alternative (tf.fill) to be consistent

    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    9e18664 View commit details
    Browse the repository at this point in the history

  9. distinguish zero bucket count case v.s. empty input data case

    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    3e72bde View commit details
    Browse the repository at this point in the history

  10. add SummaryV3OpGraphTest test case and update tests 

      TODO: figure out why `test_zero_bucket_count` doesn't work in the
  v3 graph test case (works in v3 op test case).
    @yatbear
    yatbear committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    9d32842 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. make bucket_count a variable before tf.cond op 

      Move tf.math.maximum() to the top and avoid compile time shape
  inference that fails the conditional branch that isn't supposed
  to be execute when bucket_count is 0.
    @yatbear
    yatbear committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    72cb90b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. remove debug lines added by accident

    @yatbear
    yatbear committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    2d5fafe View commit details
    Browse the repository at this point in the history