line chart: skip axis label render based on visibility #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves line chart axis by measuring how big the label is so a label does not overlap with another. Instead of using DOM to measure the dimension, this uses 2D Canvas to measure the text which is a lot performant as it would not have to cause reflow. Do note that we can be smarter with the tick filtering but this iteration is quite dumb and only filters from the start.
japie1235813
approved these changes
Sep 17, 2021
|
|
||
| const canvasForMeasure = document.createElement('canvas').getContext('2d'); | ||
|
|
||
| export function filterTicksByVisibility( |
There was a problem hiding this comment.
Could you add docstring to explain this function along with the parameters?
I do not fully understand them until read the tests. (especially getDomPos and marginBetweenAxis)
tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_axis_view.ts
Outdated
Show resolved
Hide resolved
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
This change improves line chart axis by measuring how big the label is so a label does not overlap with another. Instead of using DOM to measure the dimension, this uses 2D Canvas to measure the text which is a lot performant as it would not have to cause reflow. Do note that we can be smarter with the tick filtering but this iteration is quite dumb and only filters from the start.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
This change improves line chart axis by measuring how big the label is so a label does not overlap with another. Instead of using DOM to measure the dimension, this uses 2D Canvas to measure the text which is a lot performant as it would not have to cause reflow. Do note that we can be smarter with the tick filtering but this iteration is quite dumb and only filters from the start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves line chart axis by measuring how big the label is
so a label does not overlap with another.
Instead of using DOM to measure the dimension, this uses 2D Canvas to
measure the text which is a lot performant as it would not have to cause
reflow.
Do note that we can be smarter with the tick filtering but this
iteration is quite dumb and only filters from the start.