timeseries: show spinner when tags load #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the initial tags are loading and when it is taking a long time, users do not see anything for awhile. This can lead to a confusion and lead people to believe that something in the plugin rendered incorrectly. Now, for the initial load only, this change shows spinner for the first render.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
When the initial tags are loading and when it is taking a long time, users do not see anything for awhile. This can lead to a confusion and lead people to believe that something in the plugin rendered incorrectly. Now, for the initial load only, this change shows spinner for the first render.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
When the initial tags are loading and when it is taking a long time, users do not see anything for awhile. This can lead to a confusion and lead people to believe that something in the plugin rendered incorrectly. Now, for the initial load only, this change shows spinner for the first render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the initial tags are loading and when it is taking a long time,
users do not see anything for awhile. This can lead to a confusion and
lead people to believe that something in the plugin rendered
incorrectly.
Now, for the initial load only, this change shows spinner for the first
render.
This change had to change the data in MetricsReducers to remember the
last load time in addition to the DataLoadState so we can differentiate
first load vs. reload.