rust: add tonic-reflection dependency
#4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The [`tonic-reflection`] crate implements the gRPC reflection protocol, and will enable us to significantly simplify `grpc_cli` usage. Reflection was released in Tonic v0.4.1, so this patch also upgrades the rest of our Tonic stack to the latest versions. Test Plan: It builds: `bazel build //tensorboard/data/server/cargo:tonic_reflection`. wchargin-branch: rust-dep-tonic-reflection wchargin-source: 2a449d629fc231d697c82171c413000f1f09e645
wchargin
added
type:build/install
dependencies
|
(Sorry, this was meant to precede #4870, and does precede it in topological order.) |
…ript] wchargin-branch: rust-dep-tonic-reflection wchargin-source: 1ce18e320ee4fb02d22b5e73656dd0bc7d08109d
nfelt
approved these changes
Apr 15, 2021
tensorboard/data/server/Cargo.toml
Outdated
|
|
||
| [package.metadata.raze.crates.tonic-reflection.'0.1.0'.buildrs_additional_environment_variables] | ||
| PROTOC = "$(execpath @com_google_protobuf//:protoc)" | ||
| # we don't have easy access to a rustfmt binary, so make it a no-op |
There was a problem hiding this comment.
Maybe worth dropping a link to bazelbuild/rules_rust#87 in case this someday is easier?
There was a problem hiding this comment.
Done. For additional reference, bazelbuild/rules_rust#479 is also worth
knowing about, but not directly relevant to this comment.
wchargin-branch: rust-dep-tonic-reflection wchargin-source: ae8bd60c1c2bbc0b8e3c03081f8e9387bf391651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
tonic-reflectioncrate implements the gRPC reflection protocol,and will enable us to significantly simplify
grpc_cliusage.Reflection was released in Tonic v0.4.1, so this patch also upgrades the
rest of our Tonic stack to the latest versions.
Test Plan:
It builds:
bazel build //tensorboard/data/server/cargo:tonic_reflection.wchargin-branch: rust-dep-tonic-reflection