-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a toggle that turns automatic high-degree node extraction off #4722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this PR!
tensorboard/plugins/graph/tf_graph_controls/tf-graph-controls.ts
Outdated
Show resolved
Hide resolved
Also removes an unused property.
There's some lint left, I'll fix this when it's otherwise ready. Can you take a look whether this is better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % minor comments, I'm pleased to see this happen!
If the Prettier linting ends up being too painful, let me know and I can push a commit from my end as well.
tensorboard/plugins/graph/tf_graph_controls/tf-graph-controls.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/graph/tf_graph_controls/tf-graph-controls.ts
Outdated
Show resolved
Hide resolved
Happy to run prettier. It does propose some changes that are unrelated to my edits though -- do you want those? |
I didn't add the unrelated lint things for now. |
I'm not sure why there would be unrelated edits, unless maybe Prettier is run from another directory (running from "tensorboard_repo_dir/tensorboard/" might not pickup our settings). That said, I checked out your latest patch, ran Prettier locally, and it passed the linter locally, so it seems good to me |
Cool. Merge at will then. I can, for historical reasons, but I don't think I should. |
This adds a toggle (next to "trace inputs") which turns automatic high-degree node extraction off.
Motivation for features / changes
Automatic aux node creation can break the graph up in unwanted ways. For some graphs, the high-degree heuristic is not useful (graphs that have high-degree internal nodes, e.g., if you concatenate lots of towers or some such)
Technical description of changes
This adds an argument to the hierarchy constructor which if passed, avoids calling the high-degree node extraction code. It also removes the hard-coded PARAM entry for node extraction (which turned off all node extraction, but wasn't user settable).
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered