timeseries: add option for monotonic x #4696
Conversation
One of perennial problem of TensorBoard is zig-zaggy line chart. This happens when a directory for a run contains event files with overlapping step numbers in which case, TensorBoard will try to read them in order then sort them by wall time. Our line chart, being true to the data we are getting, does not have any special logic to break decreases in `x` and renders a zig-zags which often confuses users. This change adds a setting in timeseries to let user break such time series into a fragment where we guarantee monotonic increases in `x` within a line segment.
| <mat-icon | ||
| class="info" | ||
| svgIcon="help_outline_24px" | ||
| matTooltip="Non-monotonic steps can occur when reusing logdir with multiple summary |
There was a problem hiding this comment.
I thought our previous experiences with matTooltip (observation of bugs where it failed to reposition/disappear) led us to prefer using the web platform's .tooltip on HTMLElements instead. Are there good reasons to re-introduce matTooltip, given that this will be inconsistent with other .tooltips in the UI?
There was a problem hiding this comment.
observation of bugs where it failed to reposition/disappear
IIRC, that was not the issue. Issue was that when multiple popovers are involved, there was a significant delay and performance problem. Because we are using other kinds of popver (to name a few: modal and menu), I don't think we can workaround it all the time.
In the timeseries main content, yes, I think it is a good idea not to do without the matTooltip but I don't think we precluded it from everywhere else. In this case, with its long text, title simply are too illegible (at least on my DPI) so I very much favor using matTooltip (but it is not all that better; by default, it sets fontSize to 10px).
There was a problem hiding this comment.
With that said, I realized recent Chrome version has made the title much more salient than matTooltip so I replaced it (tho... the delay is a bit ugly).
There was a problem hiding this comment.
Thanks for switching to title, I definitely prefer having one type of tooltip rather than 2. TB does have modals and menus, but imo they are justified in having a different appearance because their behavior is different from that of tooltips (they usually require clicks to open/close rather than mouse position movement).
(btw I just realized i wrote tooltip instead of title, my bad!)
| <mat-checkbox | ||
| [checked]="scalarPartitionX" | ||
| (change)="scalarPartitionXToggled.emit()" | ||
| >Partition non-monotonic X axis</mat-checkbox |
There was a problem hiding this comment.
Hm, I'm struggling to come up with better phrasing, but I'm wondering if we might be able to get away with slightly a longer visible label that explains how the partition will occur, without always having to read the full tooltip. Maybe something like:
"Partition non-monotonic time series into multiple monotonic series"
?
There was a problem hiding this comment.
I will keep the terse phrasing at least for now.
tensorboard/webapp/metrics/views/right_pane/settings_view_component.ng.html
Outdated
Show resolved
Hide resolved
One of perennial problem of TensorBoard is zig-zaggy line chart. This
happens when a directory for a run contains event files with overlapping
step numbers in which case, TensorBoard will try to read them in order
then sort them by wall time. Our line chart, being true to the data we
are getting, does not have any special logic to break decreases in
xand renders a zig-zags which often confuses users.
This change adds a setting in timeseries to let user break such time
series into a fragment where we guarantee monotonic increases in
xwithin a line segment.