Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary scrollbar in firefox and chrome #4525

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Fix unnecessary scrollbar in firefox and chrome #4525

merged 1 commit into from
Jan 12, 2021

Conversation

japie1235813
Copy link
Contributor

  1. Replace margin with padding for the content of projector text block to prevent the body height exceeds the iframe
  2. The script tag ahead of nested iframe creates a small extra height for firefox. Apply line-heigh 0 to the body
  • Screenshots of UI changes
  • Chrome
    chrome
    Firefox
    firefox

@google-cla google-cla bot added the cla: yes label Jan 8, 2021
@stephanwlee
Copy link
Contributor

On my mac, when I enable scrollbar always, I still see one scrollbar.
image

image

Instead of line-height: 0;, I think more correct thing to do is to convert iframe into display: block (default is inline it seems, at least on FF).

WDYT?

stephanwlee
stephanwlee reviewed Jan 8, 2021
View reviewed changes
tensorboard/plugins/projector/tf_projector_plugin/index.js Outdated
@@ -22,6 +22,9 @@ iframe {
height: 100%;
margin: 0;
width: 100%;
}
body {
line-height: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be avoided if possible and is something that can be replaced with display: block.

@japie1235813 japie1235813 merged commit 860a106 into tensorflow:master Jan 12, 2021
@stephanwlee stephanwlee linked an issue Jan 12, 2021 that may be closed by this pull request
Projector plugin has triple scrollbar(!!!) on Firefox #4313
Closed
@stephanwlee stephanwlee changed the title Fix unnecessary scroller bar in firefox and chrome Fix unnecessary scrollbar in firefox and chrome Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanwlee stephanwlee stephanwlee approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Projector plugin has triple scrollbar(!!!) on Firefox
2 participants
@japie1235813 @stephanwlee