feat: reverse fill color for histograms #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Histogram reverse sorts by step number and, previously, the first step was the darkest while the last step was the faintest. While this works for most colors, it does not work well for gray based colors. Now, it is true that we have a different set of color palettes in time series and it is less of the problem but now that we let users tweak the run color, it is easy to imagine user picked color being a problem in the histograms. To alleviate the problem, we gave the most important step, the last one, the most salient color.
psybuzz
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histogram reverse sorts by step number and, previously, the first step
was the darkest while the last step was the faintest. While this works
for most colors, it does not work well for gray based colors.
Now, it is true that we have a different set of color palettes in time
series and it is less of the problem but now that we let users tweak the
run color, it is easy to imagine user picked color being a problem in
the histograms.
To alleviate the problem, we gave the most important step, the last one,
the most salient color.