Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin to redirect users to new profile plugin #3216

Merged
merged 6 commits into from
Feb 5, 2020
Merged

Add plugin to redirect users to new profile plugin #3216

merged 6 commits into from
Feb 5, 2020

Commits on Feb 5, 2020

  1. Add plugin to redirect users to new profile plugin 

    Summary:
We add a new `profile_redirect` plugin, called “Profile (moved)” in the
UI, which teaches users how to install the dynamic plugin:

![Screenshot of the new plugin][ss]

The instructions currently pull in Test PyPI sources; we’ll swap these
out for real PyPI once the package is published.

[ss]: https://user-images.githubusercontent.com/4317806/73811360-229f1300-478e-11ea-9341-f38d59170e3b.png

Test Plan:
Create a new virtualenv, install `tf-nightly`, uninstall `tb-nightly`,
and run `//tensorboard/pip_package:extract_pip_package` and install the
resulting wheel. Launch TensorBoard and note that the “Profile (moved)”
plugin appears in the inactive plugins list. Click the “Copy to
clipboard” button and execute the copied `pip install` command from the
test virtualenv. Relaunch TensorBoard, and note that the dynamic profile
plugin now appears and the “Profile (moved)” plugin is gone entirely.

Unit tests included for the conditional loading behavior. Changing the
attempted import (in `ProfileRedirectPluginLoader.load`) to a module
that always can be imported (like `sys`) causes one of the tests to
fail; changing it to one that can never be imported (like `zzz`) causes
the other to fail.

wchargin-branch: profile-redirect
    @wchargin
    wchargin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    35f7ed8 View commit details
    Browse the repository at this point in the history

  2. [update patch] 

    wchargin-branch: profile-redirect
wchargin-source: e627adb6fbe65899b25d7d79e6166593d2268107
    @wchargin
    wchargin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    3c1e4bf View commit details
    Browse the repository at this point in the history

  3. [update diffbase] 

    wchargin-branch: profile-redirect
wchargin-source: e3a25f6f2e337aa81576524367fdb9f619e7a04c
    @wchargin
    wchargin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    127726e View commit details
    Browse the repository at this point in the history

  4. [update patch] 

    wchargin-branch: profile-redirect
wchargin-source: e3a25f6f2e337aa81576524367fdb9f619e7a04c
    @wchargin
    wchargin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    d13c3a6 View commit details
    Browse the repository at this point in the history

  5. [update patch] 

    wchargin-branch: profile-redirect
wchargin-source: c832dba267a4820a123e80f7d699d7eeeb4fdf6c
    @wchargin
    wchargin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    9f54d78 View commit details
    Browse the repository at this point in the history

  6. [update patch] 

    wchargin-branch: profile-redirect
wchargin-source: 29a94e1df6ff0579dbe49cce3bceb76308709bde
    @wchargin
    wchargin committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    c532d1d View commit details
    Browse the repository at this point in the history