ci: pin to non-broken estimator nightlies #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Due to <tensorflow/tensorflow#32621>. This unblocks our CI until tomorrow’s nightlies are pushed. Test Plan: Ran this 5-line shell command (with `pip install` changed to `echo) once with `TF_VERSION_ID` set to each value from the `env` section, and noted that in all cases it succeeds and that it only prints output in the correct case. wchargin-branch: pin-estimator-20190917-nightly
|
Note that the current build on master will happen to pass because the |
|
I'm not even sure that's true for a new release branch, since it inherits the cache from master by default: https://docs.travis-ci.com/user/caching/ |
That’s… unfortunate. In any case, this way we don’t have to worry about it. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Due to tensorflow/tensorflow#32621.
This unblocks our CI until tomorrow’s nightlies are pushed.
Test Plan:
Ran this 5-line shell command (with
pip installchanged toecho) once withTF_VERSION_IDset to each value from theenv` section, and notedthat in all cases it succeeds and that it only prints output in the
correct case.
wchargin-branch: pin-estimator-20190917-nightly