Fix what-if tool display issue on example loading without inference #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswex
force-pushed
the
overviewfix
branch
from
7a04aa5
to
5650ebd
Compare
stephanwlee
approved these changes
Feb 26, 2019
wchargin
pushed a commit
to wchargin/tensorboard
that referenced
this pull request
Mar 5, 2019
…ensorflow#1898) When loading just examples, without inferring through a model (such as loading data from a csv file), still need to call refreshDive_ to fully refresh the dataset display, including calculating statistics.
Merged
wchargin
pushed a commit
that referenced
this pull request
Mar 6, 2019
…1898) When loading just examples, without inferring through a model (such as loading data from a csv file), still need to call refreshDive_ to fully refresh the dataset display, including calculating statistics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue discussed in #1794. When loading just examples, without inferring through a model (such as loading data from a csv file), still need to call refreshDive_ to fully refresh the dataset display, including calculating statistics.
Call refreshDive_ in updateExampleContents instead of just calling updateSprite
N/A
Run TensorBoard What-If Tool and provide csv file as examples to load. Navigate to "Features" tab after loading and see that Facets Overview is correctly rendered.
Ran What-If Tool demos to verify no adverse effects in other cases of data/models.