Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIT notebook mode cleanup/updates #1788

Merged
merged 21 commits into from
Jan 31, 2019
Merged

Conversation

jameswex
Copy link
Contributor

What-If Tool notebook updates:

  • Add/improve code and README documentation for notebook mode
  • Add hideImages flag for WIT polymer element to hide the documentation images in the notebook mode where the images aren't installed/hosted. Separate from local flag as in demo website mode we are in local mode but will have the documentation images.
  • Use hideImages flag in colab and juypter WIT code
  • Fix small bug in model index printing in model compare mode

Tested by:

  • Installing WitWidget locally through jupyter and tested intro notebook.
  • Testing WitWidget in colab with intro notebook.

@@ -14,4 +14,4 @@

"""Contains the version string."""

VERSION = '0.1.6a1'
VERSION = '0.1.6a4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action required: Are you actively pushing to pip or something? I am just surprised that you are updating this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes pushing to pip to get these fixes out to notebook-mode users.

@jameswex jameswex merged commit 22168a4 into tensorflow:master Jan 31, 2019
@jameswex jameswex deleted the localmode branch January 31, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants