Fix the issue where minimap content gets clipped #1600
Conversation
Bug: tensorflow#1574 Cause: the graph contains no main graph node and all nodes are auxilliary nodes. As a result, the drawn nodes are shifted right by predefined amount for visuals. When measuring the bounding box of the scene to draw the minimap, we were measuring using SVGGraphicsElement.getBBox which returned BBox without any whitespace. As a result, although we wanted the width from the origin to right edge of the right most node, we were omitting the origin to left most edge of the content resulting in clipped content in the minimap.
|
when expanding the SIR node in the provided issue reproduction event, Download PNG leaves a wide white space on the left. |
|
@PositronEternal that is how I understood the code which may not be the best for the UX. Do you expect the PNG to reflect what it roughly looks like when you "Fit to Screen" or do you expect to see just the graph? |
|
@stephanwlee I was expecting to see just the graph. Fit-to-screen moves the graph off browser for me. That is likely due to my virtual desktop size across multiple monitors and different monitor configurations as well, so unlikely to affect most users if this is the case. I was able to grab what I needed and can edit it externally. The svg branch is likely to fit my needs best, so I'll try that out. Thank you! |
Bug: #1598
Cause: the graph contains no main graph node and all nodes are
auxilliary nodes. As a result, the drawn nodes are shifted right by
predefined amount for visuals. When measuring the bounding box of the
scene to draw the minimap, we were measuring using
SVGGraphicsElement.getBBox which returned BBox without any whitespace.
As a result, although we wanted the width from the origin to right edge
of the right most node, we were omitting the origin to left most edge
of the content resulting in clipped content in the minimap.
Fixes #1598.