Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model comparison in what-if plugin v1 #1589

Merged
merged 19 commits into from
Nov 6, 2018

Conversation

tolga-b
Copy link
Contributor

@tolga-b tolga-b commented Nov 5, 2018

Adding the ability to load two models and compare them in facets as well as Datapoint Editor tab.
Adding a model comparison demo to demonstrate this feature as well.

Performance + Fairness and Partial Dependence Plots only use model 1.

@jameswex jameswex self-requested a review November 5, 2018 19:37
Copy link
Contributor

@jameswex jameswex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code was already reviewed and updated in a PR outside of the main tensorboard repo. here are some final minor comments.

@jameswex jameswex merged commit e2ba34c into tensorflow:master Nov 6, 2018
@tolga-b tolga-b mentioned this pull request Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants