Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export current line chart as SVG #1446

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Commits on Sep 27, 2018

  1. Export current line chart as SVG

    Motivation: TB should give ability to save line chart as high quality
    SVG.
    Right solution: Modify Plottable to draw in one SVG with grouping
    instead of multiple SVG fragments.
    Problem: SVG creation is scattered and it may require a lot more effort
    to understand design choice around these fragments (may require dynamic
    creation of clipPath for masking a part of a figure)
    Current solution: Parse the Plottable drawn DOM and generate one SVG out
    of the DOM snapshot
    Shortcomings:
    - X-axis label may take up larger than required space
    - There are no labels to each line (should give an option when
      exporting)
    stephanwlee committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    03d644f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    015feb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. Configuration menu
    Copy the full SHA
    dea5f7f View commit details
    Browse the repository at this point in the history