Fixed scalar card header description bug #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
reviewed
Aug 30, 2018
| // of the scalar-card if name != prefix. | ||
| if (category.metadata.type == | ||
| tf_categorization_utils.CategoryType.PREFIX_GROUP && | ||
| category.name != displayName && |
There was a problem hiding this comment.
This check is redundant with the next line
| runToTagInfo, | ||
| defaultDisplayName); | ||
|
|
||
| // If category name is a prefix group, strip the prefix from the name |
There was a problem hiding this comment.
Is this addressing #1389? If so, awesome, but ideally better to have a new feature in a separate PR rather than bundled in with a bugfix. Makes it easier for writing release notes, etc. if new features come in their own PRs.
|
Move the unnecessary change into a separate PR. Sorry about that |
As part of refactor, the categorization now returns series instead of tag and runs. This broke `_tagMetadata` not to be invoked by Polymer.
nfelt
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of refactor, the categorization now returns series instead of tag and runs. This broke
_tagMetadatanot to be invoked by Polymer.Also, the change trims scalar card title if it matches prefix.