-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add histogram coloring for xla clusters similarly to devices. #1336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
One quick question, not being very familiar with XLA - is there an easy way to generate demo/test data we could use to test this functionality?
@@ -650,32 +676,21 @@ export function getFillForNode(templateIndex, colorBy, | |||
// Return the hue for unknown device. | |||
return colorParams.UNKNOWN; | |||
} | |||
let id = renderInfo.node.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to also deduplicate the code for the TPU compatibility logic below - it looks like it was essentially copy-pasted between the device color and TPU compat color cases previously, so now that you've factored it out it would ideally be factored out in all three places.
I think it should be pretty easy to adapt, but if you'd rather not bother that's fine and one of us can clean it up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
LGTM, thanks for making those extra changes! Re: the other PR, yeah I'm not sure why the tf_graph_app index.html only shows the documentation view, I think this is one of the only places in TensorBoard that's used, perhaps for some historical reason. We could probably change it but if the demo works for you for now that's great. |
No description provided.