Make sidebar consistent across all plugins #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephanwlee
commented
Jul 18, 2018
stephanwlee
commented
- Width is now fixed (and is variable to vw)
- All slider are styled the same
- Margin and padding of content in the sidebar the same
- Made few elements respond better to variable width
nfelt
approved these changes
Jul 19, 2018
| #sidebar { | ||
| width: inherit; | ||
| flex: 0 0 25%; |
There was a problem hiding this comment.
Just to check my understanding, this CSS is what will now define the sidebar width and it's defined to be 25% of the parent (dashboard) width, bounded to a min of 270px and a max of 350px? Is that correct?
There was a problem hiding this comment.
Yup! That's correct!
- Width is now fixed (and is variable to vw) - All slider are styled the same - Margin and padding of content in the sidebar the same - Made few elements respond better to variable width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.