Make streaming_op for PR curves use tf.group. #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the streaming op for computing PR curves had relied on the `tensor_summary` method to both produce a single update op to return as well as add the update ops to various collections. That turned out problematic since it created a duplicate summary, yielding an extra PR curve plot in TensorBoard. We now use a `tf.group` op and manually add individual update ops to each collection.
nfelt
approved these changes
Mar 16, 2018
|
+1, how about now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the streaming op for computing PR curves had relied on the
tensor_summarymethod to both produce a single update op to return aswell as add the update ops to various collections. That turned out
problematic since it wrote a duplicate summary, yielding an extra PR
curve plot in TensorBoard.
We now use a
tf.groupop and manually add individual update ops toeach collection.
Fixes #965.