Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text plugin's is_active method check for data in multiplexer first before checking plugin assets. #1021

Merged
merged 8 commits into from
Mar 15, 2018

Commits on Mar 5, 2018

  1. Make text plugin short-circuit

    We make the text plugin's is_active method short-circuit if it detects
    relevant data present within the multiplexer. Subsequently, there would
    be no more need to check for data stored within plugin assets.
    chihuahua committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    7e03f80 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. Respond to comments

    chihuahua committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    aa5e3b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Respond to comments

    chihuahua committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    9706380 View commit details
    Browse the repository at this point in the history
  2. Test behavior

    Modified tests to check for correct behavior when the plugin detects
    relevant data within the multiplexer.
    
    Specifically, in that case,
    
    1. The thread that seeks plugin assets data should not start.
    2. The plugin should be active despite how that thread had not started.
    3. The tags route should respond with multiplexer data.
    chihuahua committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    220b2af View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. Fix lint

    chihuahua committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    296e44d View commit details
    Browse the repository at this point in the history
  2. Import collections

    chihuahua committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    e57b9d4 View commit details
    Browse the repository at this point in the history
  3. Remove unicode marker

    chihuahua committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    96352d6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83cb975 View commit details
    Browse the repository at this point in the history