-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projector doesn't work if I'm storing scalars too #3686
Comments
Hi @isaacgg! Thanks so much for the clear repro script; that helps a tensorboard/tensorboard/plugins/projector/projector_plugin.py Lines 345 to 348 in cdd02d7
…but as you point out this is pretty confusing and unexpected; adding You can work around this by writing the projector data to the same |
Summary: Previously, the projector plugin would look for checkpoints in the root logdir only if there were no other logs. This led to a confusing discontinuity: if you add logs to a subdirectory of a logdir with only projector data, suddenly your projector data would disappear in the UI. This patch changes the projector plugin to _always_ look in the root log directory for checkpoints. Fixes #3686. Test Plan: Three cases to test: - checkpoints in root logdir, no other data - checkpoints and summary data in root logdir - checkpoints in root logdir, summary data in non-root run Verify that each of these cases lets the projector plugin render and that the data shows up only once (i.e., it’s not duplicated). wchargin-branch: projector-always-check-root wchargin-source: 7fa825034ad74f83d4aab2bea10d2d6cd6485663
Summary: Previously, the projector plugin would look for checkpoints in the root logdir only if there were no other logs. This led to a confusing discontinuity: if you add logs to a subdirectory of a logdir with only projector data, suddenly your projector data would disappear in the UI. This patch changes the projector plugin to _always_ look in the root log directory for checkpoints. Fixes #3686. Test Plan: Three cases to test: - checkpoints in root logdir, no other data - checkpoints and summary data in root logdir - checkpoints in root logdir, summary data in non-root run Verify that each of these cases lets the projector plugin render and that the data shows up only once (i.e., it’s not duplicated). wchargin-branch: projector-always-check-root
Environment information (required)
Windows 10.
Python 3.8.3
tensorboard 2.2.1
Please run
diagnose_tensorboard.py
(link below) in the sameenvironment from which you normally run TensorFlow/TensorBoard, and
paste the output here:
https://raw.githubusercontent.com/tensorflow/tensorboard/master/tensorboard/tools/diagnose_tensorboard.py
Diagnostics
Diagnostics output
Next steps
No action items identified. Please copy ALL of the above output,
including the lines containing only backticks, into your GitHub issue
or comment. Be sure to redact any sensitive information.
For browser-related issues, please additionally specify:
Issue description
Please describe the bug as clearly as possible. How can we reproduce the
problem without additional resources (including external data files and
proprietary Python modules)?
Just as the title said, projector only works if there's no scalars being saved too.
I'm runnig tensorboard with
tensorboard --logdir=.
I've made a script to test this behaviour:
Just comment/uncomment the 14th line (
self.register_scalar()
) to test both casesThe text was updated successfully, but these errors were encountered: