Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR2/? from #774] Fix PhiloxRandom usage #785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QuantumJaeYoo
Copy link
Collaborator

This PR standardizes the way of using PhiloxRandom generators based on TensorFlow's random ops.

  • RandomOps have seed / seed2 attributes with SetIsStateful() option (codes)
  • Random generators are initialized at the constructor with OpContext (codes)
  • So the random number generator is a private member variable (codes)

@mhucka mhucka added the area/code-health Concerns stability, quality, technical debt, etc. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-health Concerns stability, quality, technical debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants