Branch 0.8.0 doesn't build on py36; unicode error

[jayfurmanek]

Hi. I'm trying to pair a TFP build with Tensorflow 1.15 (rc). I picked the TFP 0.8 branch because it has an RC tagged and has 1.15 as a requirement as listed here:

https://github.com/tensorflow/probability/blob/r0.8/tensorflow_probability/__init__.py#L56

This branch doesn't build for me. I'm using python 3.6 (anaconda).

I'm seeing the same problem as discussed in this issue:
#539
and the same fix seems to work - this commit from master:
2c54a4c

Then on the bazel-bin/pip_pkg step, I'm getting a UnicodeDecodeError: 'ascii' codec can't decode error. I found if I revert this commit, which adds in the README, it works:
8bf2f95

Update:
The first problem is fixed now (thanks!)

[brianwa84]

Yes, 0.8 is still intended to parallel the TF 2.0 release, but I've not been keeping up very well with it. Will probably get to it later today or sometime next week. Brian Patton | Software Engineer | [email protected]

…

On Fri, Sep 27, 2019 at 12:33 AM jayfurmanek ***@***.***> wrote: Hi. I'm trying to pair a TFP build with Tensorflow 1.15 (rc). I picked the TFP 0.8 branch because it has an RC tagged and has 1.15 as a requirement as listed here: https://github.com/tensorflow/probability/blob/r0.8/tensorflow_probability/__init__.py#L56 This branch doesn't build for me. I'm using python 3.6 (anaconda). I'm seeing the same problem as discussed in this issue: #539 <#539> and the same fix seems to work - this commit from master: 2c54a4c <2c54a4c> Then on the bazel-bin/pip_pkg step, I'm getting a UnicodeDecodeError: 'ascii' codec can't decode error. I found if I revert this commit, which adds in the README, it works: 8bf2f95 <8bf2f95> I don't see any recent activity on this branch - is 0.8 still being actively developed? Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#571?email_source=notifications&email_token=AFJFSI6QRGHJIZG2WHAYH5TQLWELHA5CNFSM4I3BV4C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOBUEJA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFJFSIZP5SVLKVNNFQU4VYTQLWELHANCNFSM4I3BV4CQ> .

[jayfurmanek]

OK. thanks! Is there a release that is intended to parallel TF 1.15 then?

I still think the cherry-pick is needed in any case.

[jayfurmanek]

I do see this commit though:
bb302df

Which is why I was confused a bit.

[brianwa84]

I will try to have 0.8.0 compatible with both 1.15 and 2.0, since they are progressing simultaneously. Do you have the same issues with the master branch, or other failures with 1.15? The 'ascii' one is new to me, I don't think we've seen that before and we're building/uploading a pip pkg every night for tfp-nightly. https://pypi.org/project/tfp-nightly/ Maybe a specific characteristic of your python/linux install? AFAIK, there shouldn't be any unicode in that README.md. Note, we use python3 for our pip upload, so maybe there's an issue with 2.7 (which we probably won't fix, given 12/31 end of support). Brian Patton | Software Engineer | [email protected]

…

On Fri, Sep 27, 2019 at 12:01 PM jayfurmanek ***@***.***> wrote: I do see this commit though: bb302df <bb302df> Which is why I was confused a bit. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#571?email_source=notifications&email_token=AFJFSI5VTGOOLCDSYYZEDQLQLYU35A5CNFSM4I3BV4C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ZLIQA#issuecomment-535999552>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFJFSI7UXMOIZT5ZPQRA3ATQLYU35ANCNFSM4I3BV4CQ> .

[jayfurmanek]

Master seems to be ok for the import problem. I still see the unicode problem though.
I'm using py36, which is why the unicode problem is strange. It's Anacoda py36, but that should'nt make a difference. Pulling the README out does avoid the problem.

I will try to have 0.8.0 compatible with both 1.15 and 2.0, since they are progressing simultaneously.

This is good to know, thanks. I don't see any other issue vs 1.15, but have not really run anything yet since it I thought it was only for 2.0. I can try it a bit more.

[jayfurmanek]

Thanks for the cherry-pick!
On the README issue, I still see the unicode problem, but only on python 3.6. It works fine on python 3.7, which is odd.

[brianwa84]

Ah, I haven't tried w/ 3.6. We test 3.5 and 3.7 nowadays. Brian Patton | Software Engineer | [email protected]

…

On Tue, Oct 1, 2019 at 6:12 PM jayfurmanek ***@***.***> wrote: Thanks for the cherry-pick! On the README issue, I still see the unicode problem, but only on python 3.6. It works fine on python 3.7, which is odd. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#571?email_source=notifications&email_token=AFJFSI37PJMRMMY7MYY67QTQMPDLNA5CNFSM4I3BV4C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAC5VBA#issuecomment-537254532>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFJFSI6SA4DLO2VBOJTZWOTQMPDLNANCNFSM4I3BV4CQ> .