[audio] cleanup vorbis file after usage (#1249)

* [audio] cleanup vorbis file after usage * move the file cleanup to destructor
tensorflow · Dec 27, 2020 · 1c90427 · 1c90427
1 parent c409778
commit 1c90427
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/tensorflow_io/core/kernels/audio_video_ogg_kernels.cc b/tensorflow_io/core/kernels/audio_video_ogg_kernels.cc
@@ -83,7 +83,10 @@ static ov_callbacks OggVorbisCallbacks = {
 class OggVorbisReadableResource : public AudioReadableResourceBase {
  public:
   OggVorbisReadableResource(Env* env) : env_(env) {}
-  ~OggVorbisReadableResource() {}
+  ~OggVorbisReadableResource() {
+    // Cleanup the vorbis file
+    ov_clear(&ogg_vorbis_file_);
+  }
 
   Status Init(const string& filename, const void* optional_memory,
               const size_t optional_length) override {
@@ -142,8 +145,8 @@ class OggVorbisReadableResource : public AudioReadableResourceBase {
 
     long samples_read = 0;
     long samples_to_read = value->shape().dim_size(0);
+    float** buffer;
     while (samples_read < samples_to_read) {
-      float** buffer;
       int bitstream = 0;
       long chunk = ov_read_float(&ogg_vorbis_file_, &buffer,
                                  samples_to_read - samples_read, &bitstream);
@@ -160,6 +163,7 @@ class OggVorbisReadableResource : public AudioReadableResourceBase {
       }
       samples_read += chunk;
     }
+
     return Status::OK();
   }
   string DebugString() const override { return "OggVorbisReadableResource"; }