Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Fix stack overflow of bash when copying tf headers #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mareikethies
Copy link

Fixes issue described in #87. Putting together the copy command for tf headers in tf_configure.bzl using " && " causes a stack overflow in msys2 bash.exe on windows. Executing each copy as a single command (via "\n") prevents this.

Copy link

@maxrohleder maxrohleder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I experienced the same issue on powershell with msys2 base.exe enabled. With the proposed changes, it works like a charm.

I would never have discovered the stackoverflow as this line:

     0 [] bash 1410 cygwin_exception::open_stackdumpfile: Dumping stack trace to bash.exe.stackdump

was missing in the log on powershell...

Thank you so much for this @mareikethies!

@akmaier
Copy link

akmaier commented Apr 20, 2021

This would also totally help my project! There might be other issues down the line and we would be glad to track and fix them!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants