feature: support runtime init script #1085
Conversation
Signed-off-by: Jinjing.Zhou <[email protected]>
Signed-off-by: Jinjing.Zhou <[email protected]>
Signed-off-by: Jinjing.Zhou <[email protected]>
Signed-off-by: Jinjing.Zhou <[email protected]>
VoVAllen
changed the title
|
@gaocegege @kemingy PTAL |
| ruleDaemon = "runtime.daemon" | ||
| ruleEnviron = "runtime.environ" | ||
| ruleMount = "runtime.mount" | ||
| ruleInitScript = "runtime.init_script" |
There was a problem hiding this comment.
Is it better to name as runtime.init?
| ruleDaemon = "runtime.daemon" | ||
| ruleEnviron = "runtime.environ" | ||
| ruleMount = "runtime.mount" | ||
| ruleInitScript = "runtime.init_script" |
| user = "${USER}" | ||
| working-directory = "${%[3]s}" | ||
| %[4]s |
There was a problem hiding this comment.
I wonder if this is too flexible. Currently, we only need the start-after.
Maybe we can switch to a TOML tool to generate it if it becomes more complex in the future.
There was a problem hiding this comment.
We can refactor this once we need more controls here.
|
LGTM |
|
Sorry, I closed it in accident. |
Signed-off-by: Jinjing.Zhou <[email protected]>
examples/dpgen2/build.envd
Outdated
| @@ -0,0 +1,40 @@ | |||
| def install_kubectl_kind(): | |||
There was a problem hiding this comment.
Should we keep it in envd examples or envdlib?
There was a problem hiding this comment.
It's not general enough now. sudo docker network connect kind dpgen2 means only project named as dpgen2 will work
There was a problem hiding this comment.
Could we make like this:
def install_kubectl_kind(environment_name):
There was a problem hiding this comment.
Changed to def install_kubectl_kind(env_name). But I still think kind is not a general requirement. Thus I don't think we don't need to put it into envdlib
Signed-off-by: Jinjing.Zhou <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, kemingy, VoVAllen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
support
runtime.init