rocksdb: handle reuse of closed batches #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
reviewed
Mar 9, 2020
| return err | ||
| func (b *rocksDBBatch) Write() error { | ||
| if b.batch == nil { | ||
| return nil |
There was a problem hiding this comment.
I believe we need to return an error instead of silently ignoring write. we should help developer uncover his/her errors (not executing Set/Delete on batch), not ignoring them.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure, I'll submit a new PR. It will be a bit more breaking, because we have to change the Batch interface to return errors etc, but I agree it's a better solution.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug uncovered by new tests.