memdb: API cleanups and improvements #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
reviewed
Mar 4, 2020
melekes
reviewed
Mar 4, 2020
tessr
reviewed
Mar 9, 2020
mem_db.go
Outdated
| return newMemDBIterator(db.btree, start, end, true), nil | ||
| } | ||
|
|
||
| //---------------------------------------- | ||
| // Iterator |
There was a problem hiding this comment.
We've been talking for a long time about getting rid of these ascii separators and instead putting things in their own files. Do you want to do that while you're in here cleaning things up? (Could also go in a follow up PR, since it might create a lot of noise in this one.)
There was a problem hiding this comment.
I split the iterator and batch into separate files, but kept them in the root directory since using a separate directory would break the API quite severely. I also renamed files from e.g. mem_db_iterator.go to memdb_iterator.go.
Let me know if you think this is fine, and I'll merge this and submit a PR that does the same for the other backends.
|
Nice. Happy to see an unused DB removed! |
tessr
approved these changes
Mar 9, 2020
Co-Authored-By: Anton Kaliaev <[email protected]>
erikgrinaker
force-pushed
the
erik/memdb-api
branch
from
4752398
to
ec62470
Compare
Co-Authored-By: Anton Kaliaev <[email protected]>
faddat
pushed a commit
to faddat/tm-db
that referenced
this pull request
Feb 21, 2024
…rmint#56) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.55.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.55.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54, fixes #55. Somewhat breaking, since we're removing exported methods, but these are not likely to be widely used.
RWMutexinstead of aMutexin MemDBmockDBsince it is not really usedBranched off of #53, should be rebased onto
masterbefore merging.